Use setTimer in NetworkManager.startPeriodicCatchup #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These need to be replaced to use setTimer once TaskManager is fixed to use it.
| @@ -430,6 +430,10 @@ public class NetworkManager | |||
| address, &onHandshakeComplete, &onFailedRequest); | |||
| } | |||
| } | |||
|
|
|||
| connnectionTask(); // avoid delay | |||
| this.taskman.setTimer(this.node_config.retry_delay.msecs, | |||
There was a problem hiding this comment.
This is not correct. Previously the calling fiber was yielded, but here you are spawning a new one. You're going to end up with multiple fibers running within this class. This part should not be changed.
There was a problem hiding this comment.
That's what I was curious about. Thank you for your clear answer.
There was a problem hiding this comment.
The commit has been deleted.
TrustHenry
changed the title
Codecov Report
@@ Coverage Diff @@
## v0.x.x #921 +/- ##
==========================================
- Coverage 90.45% 90.45% -0.01%
==========================================
Files 71 71
Lines 5669 5668 -1
==========================================
- Hits 5128 5127 -1
Misses 541 541
Continue to review full report at Codecov.
|
AndrejMitrovic
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These need to be replaced to use setTimer once TaskManager is fixed to use it.
Relates #872