Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency on PCL headers #9

Merged

Conversation

Rayman
Copy link
Contributor

@Rayman Rayman commented Jun 25, 2024

When I try to build this package on jazzy with rosdep, the PCL headers are missing. This package uses find_package(PCL) and includes it in the headers. Therefore I think it would be best to add it to the build_depend and build_export_depend tags of the package.xml files.

In the buildfarm this is technically not needed because the PCL headers are a build_export_depend of pcl_conversions, but rosdep ignores this dependency so it misses the PCL headers.

How to reproduce:

FROM ros:jazzy
RUN apt-get update && apt-get upgrade -y
WORKDIR /root/src
RUN git clone https://github.com/bosch-engineering/off_highway_sensor_drivers.git
WORKDIR /root
RUN rosdep install --from-paths /root/src -i -y
RUN . /opt/ros/jazzy/setup.sh && colcon build --event-handlers console_direct+

@rcp1-beg
Copy link
Collaborator

rcp1-beg commented Jul 1, 2024

Can you sign-off your commit?

@rcp1-beg
Copy link
Collaborator

rcp1-beg commented Jul 1, 2024

Yes, you are right, it only works as long as libpcl-dev is installed since this is - sadly - the only package / component of PCL which installs the PCL headers... I didn't see that the components like pcl-common are plain shared objects.

Your changes lgtm. It is a bit sad that one needs to install the full PCL including a JDK for visualization just to include types from it.

Under humble libpcl-dev was installed by pcl_ros 2.4.0.

When I try to build this package on jazzy with rosdep, the PCL headers
are missing. This package uses `find_package(PCL)` and includes it in
the headers. Therefore I think it would be best to add it to the
`build_depend` and `build_export_depend` tags of the `package.xml`
files.

In the buildfarm this is technically not needed because the PCL headers
are a `build_export_depend` of `pcl_conversions`, but rosdep ignores
this dependency so it misses the PCL headers.

Signed-off-by: Ramon Wijnands <ramon.wijnands@nobleo.nl>
@Rayman
Copy link
Contributor Author

Rayman commented Jul 1, 2024

I've signed my commit now.

Note that libpcl-dev is only installed during build. For runtime its not needed (no exec_depend)

@rcp1-beg rcp1-beg merged commit 51056b8 into bosch-engineering:humble-devel Jul 1, 2024
@Rayman Rayman deleted the fix/missing-dependencies branch July 1, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants