Skip to content

Commit

Permalink
[velbus] Fix typo in the Counter Channel name for VMB7IN (openhab#11521
Browse files Browse the repository at this point in the history
…) (openhab#11553)

* [velbus] Add new functionality PRESSED and LONG PRESSED and fix bug

New functionnality :
Add the the possibility to simulate the PRESSED and LONG PRESSED message of an input.

Module supported with button simulation :
VMB1RYS (button : CH6)
VMB6IN (buttons : CH1 ... CH6)
VMB2PBN, VMB6PBN, VMB7IN, VMB8IR, VMB8PB, VMB8PBU, VMBEL1, VMBEL2, VMBEL4, VMBGP1, VMBGP1-2, VMBGP2, VMBGP2-2, VMBGP4, VMBGP4-2, VMBGP4PIR, VMBGP4PIR-2 (buttons : CH1 ... CH8)
VMBELO, VMBGPOD, VMBGPOD-2 (buttons : CH1 ... CH32)

Fix bug :

The channels names were not correctly assigned to the thing properties. The last channel had the default name, not the one retrieved from the module.

Signed-off-by: Daniel Rosengarten <github@praetorians.be>

* Update bundles/org.openhab.binding.velbus/README.md

Co-authored-by: cedricboon <cedric.boon@hotmail.com>
Signed-off-by: Daniel Rosengarten <github@praetorians.be>

* Update bundles/org.openhab.binding.velbus/README.md

Co-authored-by: cedricboon <cedric.boon@hotmail.com>
Signed-off-by: Daniel Rosengarten <github@praetorians.be>

* Update bundles/org.openhab.binding.velbus/README.md

Co-authored-by: cedricboon <cedric.boon@hotmail.com>
Signed-off-by: Daniel Rosengarten <github@praetorians.be>

* Add trigger on channel when using button simulation

Remove uneeded  Thread.sleep in code.
Trigger the events PRESSED, LONG_PRESSED, RELEASED on the linked trigger channel when using the button simulation.

Signed-off-by: Daniel Rosengarten <github@praetorians.be>

* Fix redundant superinterface DiscoveryService

Redundant superinterface DiscoveryService for the type VelbusThingDiscoveryService, already defined by AbstractDiscoveryService.

Signed-off-by: Daniel Rosengarten <github@praetorians.be>

* Fix bug openhab#11521

Typo in the Counter Channel name for VMB7IN.

Signed-off-by: Daniel Rosengarten <github@praetorians.be>

Co-authored-by: cedricboon <cedric.boon@hotmail.com>
  • Loading branch information
Rosen01 and cedricboon committed Nov 12, 2021
1 parent c39d1e9 commit bf03062
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -1072,7 +1072,7 @@
<channels>
<channel id="counter1" typeId="counter"/>
<channel id="counter1Current" typeId="counter"/>
<channel id="counter" typeId="counter"/>
<channel id="counter2" typeId="counter"/>
<channel id="counter2Current" typeId="counter"/>
<channel id="counter3" typeId="counter"/>
<channel id="counter3Current" typeId="counter"/>
Expand Down

0 comments on commit bf03062

Please sign in to comment.