Try to stop everything before setting config list #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Laible <stefan.laible@de.bosch.com>
Signed-off-by: Stefan Laible <stefan.laible@de.bosch.com>
Signed-off-by: Stefan Laible <stefan.laible@de.bosch.com>
Signed-off-by: Stefan Laible <stefan.laible@de.bosch.com>
|
|
Signed-off-by: Stefan Laible <stefan.laible@de.bosch.com>
Signed-off-by: Stefan Laible <stefan.laible@de.bosch.com>
@kfabian, thanks for the hint. I changed the version to v0.2. I thought using a new version would maybe solve Build action (utils): Galactic, but it is still failing. The build fails when the pep257 test is processing the python launch file of the utils package. Running the same test locally, the test succeeds. |
kfabian
approved these changes
Mar 13, 2023
Signed-off-by: Stefan Laible <stefan.laible@de.bosch.com>
syyuen
approved these changes
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The bridge tries to set the config parameters when starting. When the localization (or something else) is already running at the beginning, setting config parameters at the same time is not possible in the Locator, and the bridge crashes. To fix this, you have to use, for example, the aXessor.
Solution:
Try to stop everything before setting the parameters.
Better solution:
Instead of just trying to stop everything, it would be better to check the state of the Locator before. But information at the ClientControlMode interface is only available at state changes. Is there another API for checking the states, @syyuen, @HWasserfuhr ?