Extend motorbike profile and include profiles in builds #16
Conversation
erikbosch
force-pushed
the
erikbosch/erik_motorbike
branch
from
282faac
to
de1cf06
Compare
.github/workflows/buildcheck.yml
Outdated
| @@ -25,9 +25,13 @@ jobs: | |||
| python -V | |||
| python -m pip --quiet --no-input install --upgrade pip | |||
| python -m pip --quiet --no-input install --upgrade pipenv wheel | |||
| pipenv --version | |||
There was a problem hiding this comment.
This file actually does not belong to this PR, shown here as github could not detect the rebase
| @@ -37,6 +37,11 @@ csv: | |||
| ddsidl: | |||
| ${TOOLSDIR}/vspec2ddsidl.py -I ./spec ./spec/VehicleSignalSpecification.vspec vss_rel_$$(cat VERSION).idl | |||
|
|
|||
| # Verifies that supported overlay combinations are syntactically correct. | |||
| overlays: | |||
There was a problem hiding this comment.
Only indirectly related to the contribution - make sure that the overlay is syntactically correct
overlays/profiles/motorbike.vspec
Outdated
| description: Indicates if IMU is working. True = OK. False = Failure. | ||
|
|
||
| # Next branch and signal can be removed when https://github.com/COVESA/vehicle_signal_specification/pull/478 is merged |
There was a problem hiding this comment.
Added this comment, will update this PR when the other is merged
overlays/profiles/motorbike.vspec
Outdated
| datatype: boolean | ||
| description: Indicates if the Clutch switch is operated, so engine and transmission are decoupled. False = Clutch switch not operated. True = Clutch switch operated. | ||
| comment: True corresponds to that Vehicle.Powertrain.Transmission.ClutchEngagement is 0.0 or very close to 0.0. |
There was a problem hiding this comment.
Some minor change here - I changed the signal name to comply with VSS "Is*" naming recommendation. But then It got a bit unsure on what we mean with this signal vs. Vehicle.Powertrain.Transmission.ClutchEngagement. Shall this be true as soon as you barely move the clutch switch, i.e. corresponding to ClutchEngagement is just below 100%, or shall it be true first when ClutchEngagement is almost 0?
Makefile
Outdated
| @@ -37,6 +37,11 @@ csv: | |||
| ddsidl: | |||
| ${TOOLSDIR}/vspec2ddsidl.py -I ./spec ./spec/VehicleSignalSpecification.vspec vss_rel_$$(cat VERSION).idl | |||
|
|
|||
| # Verifies that supported overlay combinations are syntactically correct. | |||
| overlays: | |||
| ${TOOLSDIR}/vspec2csv.py -I ./spec -o overlays/profiles/motorbike.vspec ./spec/VehicleSignalSpecification.vspec vss_rel_$$(cat VERSION)_motorbike.idl | |||
There was a problem hiding this comment.
Doesn't matter for the intended goal of checking "parsability" of the overlay, but test uses vspec2csv however saves result to .idl
ceterum censeo vspec2json ist the only tool that counts 😛
erikbosch
force-pushed
the
erikbosch/erik_motorbike
branch
from
de1cf06
to
31f7cbd
Compare
This PR contains some signals relevant to motorbikes. Some of them might be of general interest and may be moved to "standard vss" later. Signed-off-by: Erik Jaegervall <erik.jaegervall@se.bosch.com>
erikbosch
force-pushed
the
erikbosch/erik_motorbike
branch
from
31f7cbd
to
6f7ba1a
Compare
|
Replaced by COVESA#487 |
This PR contains some signals relevant to motorbikes.
Some of them might be of general interest and may be moved to
"standard vss" later.
Signed-off-by: Erik Jaegervall erik.jaegervall@se.bosch.com