Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exit code when performing a fix #51

Closed
erwanncloarec opened this issue May 29, 2024 · 0 comments · Fixed by #52
Closed

Exit code when performing a fix #51

erwanncloarec opened this issue May 29, 2024 · 0 comments · Fixed by #52

Comments

@erwanncloarec
Copy link
Contributor

Current behavior:

When performing with success a fix cargo shear --fix the exit code is 1, even if the fix is successful and there is no unused dependencies at the end.

Proposed behavior:

When performing with success a fix cargo shear --fix the exit code is 0 when there is no unused dependencies at the end.

Why:

We can have automatic hooks that will fail even though the fix operation is successful. It's the behavior of other tools like eslint or biome.

Thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant