Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API: Node info #9

Closed
spikeekips opened this issue Jun 1, 2018 · 13 comments · Fixed by #534
Closed

API: Node info #9

spikeekips opened this issue Jun 1, 2018 · 13 comments · Fixed by #534
Assignees
Labels
API enhancement New feature or request

Comments

@spikeekips
Copy link
Contributor

spikeekips commented Jun 1, 2018

The basic node information will be produced,

@spikeekips spikeekips added this to the Opening Testnet milestone Jun 1, 2018
@spikeekips spikeekips added the enhancement New feature or request label Jun 1, 2018
@anarcher
Copy link
Contributor

anarcher commented Jun 5, 2018

What kind of node status is exist in node? IMHO, the node may have several statuses like below:

  • Starting
  • Catchup
  • Synced
  • Terminating

But I am not entriely sure that the statues are good naming or meaning to represent of node status.
What do you think about it?

ps) state can be better naming than status.. And status can display additional information (message log style?)

@spikeekips
Copy link
Contributor Author

@anarcher What kind of node status is exist in node? IMHO, the node may have several statuses like below:

  • Starting
  • Catchup
  • Synced
  • Terminating

Several names are almost same I proposed at #11

  • booting == Starting
  • catchup == catchup
  • consensus == synced

synced is the Stellar's term, so instead of that I want to use our own expression, booting. terminating is I missed, it can show that node is terminating with any reason.

But I am not entriely sure that the statues are good naming or meaning to represent of node status.
What do you think about it?

ps) state can be better naming than status.. And status can display additional information (message log style?)

'state' also has same meaning with 'status', but state is already used for ballot state like BallotStateINIT, BallotStateSIGN, so I think 'status' is good term. :) If you have another alternatives of 'status', let us know.

@anarcher
Copy link
Contributor

anarcher commented Jun 5, 2018

I agree consensus is better than synced. :-) also, status make sense :-)
I missed #10
Thanks :-)

@leejames00
Copy link
Contributor

Is Consensus intended for the nodes that have all (up to date) blockchain data ?
In that case, I think synced is better.

@outsideris
Copy link
Contributor

How about consensus to consented or consenting.
consensus is nouns, so it is confused about what it represents for.

@leejames00
Copy link
Contributor

I agree on not using consensus, but I can't think of a term to replace it

@spikeekips
Copy link
Contributor Author

@outsideris @leejames00 I mean that consensus is the node can participate consensus process.

This was referenced Jun 27, 2018
@Charleslee522 Charleslee522 added this to To do in Iteration 18-01 via automation Jul 9, 2018
@spikeekips spikeekips added the API label Sep 10, 2018
@kfangw
Copy link
Contributor

kfangw commented Sep 14, 2018

several weeks ago I had been worked for this issue with PR #143
Do you think that this issue needed to be resumed? or any other opinion?
@anarcher

@kfangw
Copy link
Contributor

kfangw commented Sep 17, 2018

several weeks ago I had been worked for this issue with PR #143
Do you think that this issue needed to be resumed? or any other opinion?
@anarcher

@anarcher ping

@anarcher
Copy link
Contributor

IMHO, we consider to separate node info and client info. What do you think? :)

@kfangw
Copy link
Contributor

kfangw commented Sep 17, 2018

OK I agreed. What information provided by the client node API you think?

@anarcher
Copy link
Contributor

anarcher commented Sep 17, 2018

What do you think about it? :->

type Info struct {
    NodeVersion string `json:node_version`  // version/version
    NodeState  string `json:node_state`  // node/localNode.state
    NodeAlias  string `json:node_alias` // node/localNode.Alias
    BlockHeight uint64 `json:block_height`  // block/Block
}

@kfangw
Copy link
Contributor

kfangw commented Sep 17, 2018

@anarcher thx ~ I will make a node API for a client based on what you suggested

spikeekips added a commit that referenced this issue Oct 18, 2018
Basic node information including sebak version and it's `node.State`
* `node` Is is marshaled fro node.NodeInfo
* `block` part contains the latest block information
* `policy` part contains basic constants and numbers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

6 participants