Enable strict specification parsing

badwolf/spec.py

@@ -33,7 +33,8 @@ def _deserialize(self, value, attr, data):
             try:
                 result.append(self.container.deserialize(each))
             except ValidationError as e:
-                result.append(e.data)
+                if e.data is not None:
+                    result.append(e.data)
                 errors.update({idx: e.messages})
 
         if errors:
@@ -166,6 +167,9 @@ class AnyDeploySchema(OneOfSchema):
 
 
 class SpecificationSchema(Schema):
+    class Meta:
+        strict = True
+
     image = fields.String(missing=None)
     dockerfile = fields.String(missing='Dockerfile')
     docker = fields.Boolean(missing=False)

tests/test_spec.py

@@ -1,6 +1,7 @@
 # -*- coding: utf-8 -*-
 import io
 
+import pytest
 from marshmallow import Schema, fields
 
 from badwolf.spec import Specification
@@ -473,3 +474,14 @@ def test_deploy_multiple_provider(app):
     assert pypi.provider == 'pypi'
     assert pypi.username == 'test'
     assert pypi.password == 'test'
+
+
+def test_deploy_single_provider_object_should_fail(app):
+    from badwolf.exceptions import InvalidSpecification
+
+    s = """deploy:
+  script: echo test
+  tag: true"""
+    f = io.StringIO(s)
+    with pytest.raises(InvalidSpecification):
+        Specification.parse_file(f)