Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ravi/Aishwarya | Allow okta-config to be present outside the bundled jar #4

Merged
merged 1 commit into from Sep 13, 2020
Merged

Ravi/Aishwarya | Allow okta-config to be present outside the bundled jar #4

merged 1 commit into from Sep 13, 2020

Conversation

ravik-karn-tw
Copy link
Contributor

No description provided.

@ravik-karn-tw ravik-karn-tw mentioned this pull request Sep 11, 2020
Closed
bostonaholic
bostonaholic requested changes Sep 12, 2020
View reviewed changes
Copy link
Owner

@bostonaholic bostonaholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I believe these changes make sense. Thank you for the PR. I have one small suggestion before merging.

src/ring/ring_okta/session.clj Outdated
@@ -5,7 +5,7 @@
[ring.util.response :as response]))

(defn login [{:keys [okta-config-location params]}]
(let [okta-response (saml/respond-to-okta-post (slurp (io/resource okta-config-location)) params)]
(let [okta-response (saml/respond-to-okta-post (slurp (io/reader okta-config-location)) params)]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the docs for clojure.java.io/reader suggest:

Should be used inside with-open to ensure the Reader is properly closed.

https://clojure.github.io/clojure/clojure.java.io-api.html#clojure.java.io/reader

Is it possible for you to wrap the call in with-open as the docs suggest?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion..

I have made the required changes

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ravik-karn-tw. Looks good to me! I'll be merging and releasing 0.5.0 shortly.

@bostonaholic
Copy link
Owner

Also, I made some minor code style changes on master. You may need to rebase your branch to clean up the conflicts. My apologies.

bostonaholic
bostonaholic approved these changes Sep 13, 2020
View reviewed changes
Copy link
Owner

@bostonaholic bostonaholic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feature suggestion and putting in the work to make it happen!

@bostonaholic bostonaholic merged commit b64aa70 into bostonaholic:master Sep 13, 2020
@bostonaholic
Copy link
Owner

@ravik-karn-tw This has been merged and released as 0.5.0. Please let me know if you have any issues. Thanks again for you help!

@ravik-karn-tw
Copy link
Contributor Author

@ravik-karn-tw This has been merged and released as 0.5.0. Please let me know if you have any issues. Thanks again for you help!

@bostonaholic Thanks for the help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bostonaholic bostonaholic bostonaholic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ravik-karn-tw @bostonaholic