Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.0 #6

Merged
merged 9 commits into from
Oct 16, 2020
Merged

Release v1.0 #6

merged 9 commits into from
Oct 16, 2020

Conversation

bostrom
Copy link
Owner

@bostrom bostrom commented Oct 16, 2020

TL;DR: This branch includes planned version updates for our initial game launch.

Planned 🚢 date: soon

Features:

  • updated readme

Bug fixes:

@github-learning-lab
Copy link
Contributor

Uh oh, the title of your pull request isn't right.

⌨️ Activity: Fix the title

I was expecting a title of: Release v1.0


I'll respond in this pull request when you've changed the title.

@bostrom bostrom changed the title Release v1.0 tracker Release v1.0 Oct 16, 2020
@github-learning-lab
Copy link
Contributor

Release branches are long lived, and we opened a pull request for another feature change. This will give our release a more detailed history. We changed the default text to green instead of white.

Several changes might be included in release branches. This is a common practice, and allows you to continue to ship code quickly without blockers.


Head over to the next pull request for your next steps.

More features for the next release
@github-learning-lab
Copy link
Contributor

Automating releases

Now that our release branch is ready to be merged, we have two more steps to take.

First, let's make sure that we're set up to document the version changes for the users.

Step 8: Install and configure a GitHub app

We'll be using the Release Drafter GitHub app to draft our release notes as pull requests are merged.

The Release Drafter updates releases, so it requires write access to this repository. When you install the app, you don't need to add it to your entire GitHub account. Only install it on this repository. Release Drafter doesn't work just out of the box. If you use this in the future, you'll need to add .github/release-drafter.yml to your repository. We'll take care of adding this in a separate PR.

⌨️ Activity: Install the Release Drafter GitHub app

  1. Install the Release Drafter GitHub app to this repository only.
  2. Open a new pull request with base: release-v1.0 and compare: config-release-drafter. This will add the configuration file for Release Drafter to this repository.

Note: For privacy reasons, we can't see what other apps have access to this repository, so we'll take your word for it.


I'll respond in your new pull request.

Sometimes I respond too fast for the page to update! If you don't see a response from me, wait a few seconds and refresh the page for your next steps.

Copy link
Contributor

@github-learning-lab github-learning-lab bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 10: Merge the release branch

Because the master branch is protected, this pull request couldn't be merged until it received an approval. I've gone ahead and approved this one for you. It looks great!

It's generally a good idea to make sure that branches, especially long-lived ones like release branches, have the approval of your peers. Go ahead and merge before we move onto our next steps.

⌨️ Activity: Merge into master

  1. Click Merge pull request.

Note: Usually, you delete a branch after merging. The release branch is protected, so it cannot be deleted.


Merge, then look for my response below.

@bostrom bostrom merged commit e1c4082 into master Oct 16, 2020
@github-learning-lab
Copy link
Contributor

Thanks for the merge. Notice that I didn't delete the branch? That's intentional.

Sometimes mistakes can happen with releases, and we'll want to be able to correct them on the same branch. Before we worry about any of that, let's finalize our first release!

Look for instructions in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants