Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: fix related to saving files in print_pdf method - Issue #20 #24

Merged

Conversation

joao-voltarelli
Copy link
Contributor

@joao-voltarelli joao-voltarelli commented Jan 21, 2022

Added changes:

  • New key in "prefs" dict in Chrome and Edge, to automatically download pdf files instead of opening a page with pdf viewer.
  • Added check_file_count method to count the amount of files of a certain type in a folder.
  • Added wait_for_new_pdf method to wait for the pdf file to be saved in the folder, when you don't have the exact file path.
  • Added return_last_created_file method to return the last file that was created/downloaded in a folder.
  • Changes in the print_pdf method to save the files in the correct path, using the new methods created.

Closes #20

Copy link
Contributor

@hhslepicka hhslepicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @joao-voltarelli! Thank you for resolving this bug.

@hhslepicka hhslepicka merged commit 51984b2 into botcity-dev:main Feb 4, 2022
@joao-voltarelli joao-voltarelli deleted the fix/master/print_pdf_fix branch February 7, 2022 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in print_pdf method when the url is a viewer page of a pdf file (e.g., Chrome PDF Viewer).
2 participants