Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: fix related to wait_for_downloads method when used on edge - Issue #23 #25

Merged
merged 2 commits into from
Jan 25, 2022
Merged

BUG: fix related to wait_for_downloads method when used on edge - Issue #23 #25

merged 2 commits into from
Jan 25, 2022

Conversation

joao-voltarelli
Copy link
Contributor

Added changes:

  • Change in the Javascript command responsible for accessing the downloads page and manipulating the DOM in the Edge browser.

@hhslepicka
Copy link
Contributor

Closes #23

hhslepicka
hhslepicka approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@hhslepicka hhslepicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, @joao-voltarelli

@hhslepicka hhslepicka merged commit ef33bba into botcity-dev:main Jan 25, 2022
@hhslepicka hhslepicka mentioned this pull request Jan 25, 2022
Closed
@joao-voltarelli joao-voltarelli deleted the fix/master/wait_for_downloads_edge_fix branch January 26, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hhslepicka hhslepicka hhslepicka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joao-voltarelli @hhslepicka