Skip to content
This repository has been archived by the owner on May 5, 2021. It is now read-only.

refactor: hide the image not found icon before setting the image #706

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

GuillaumeTech
Copy link
Contributor

hide Image not found icon when creating a image response

  • I wrote tests for the feature
  • I documented the feature if needed

If the feature is a refactor, please explain why your way is better

@znat znat added this to the 0.26 milestone Aug 12, 2020
@GuillaumeTech
Copy link
Contributor Author

The failling test is the training test one, when it utter fallback instead of utter hi

@pheel pheel self-requested a review August 12, 2020 17:23
Copy link
Contributor

@pheel pheel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before (FF/Chrome):
Screen Shot 2020-08-12 at 1 23 06 PM
After:
Screen Shot 2020-08-12 at 1 22 42 PM

@pheel pheel self-requested a review August 13, 2020 18:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants