Kill worker on UnknownResourceFault's during a heartbeat (#88) #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we use SIGKILL here, which might look a bit violent for the purpose of stopping a process (the process won't be able to cleanup anything before dying for instance). This should probably be a SIGTERM but we already handle SIGTERM signals today and we alias it to a graceful shutdown. Maybe we should change this behavior, but that's a first version. Closes #88.
ybastide
reviewed
May 18, 2017
| # that the worker process is still alive. | ||
| os.kill(worker.pid, signal.SIGKILL) | ||
| except OSError as e: | ||
| if "No such process" not in e.strerror: |
There was a problem hiding this comment.
if e.errno != errno.ESRCH:
|
Check failed: json_dumps need to set sort_key; PR incoming. |
ybastide
reviewed
May 18, 2017
| @@ -229,7 +229,8 @@ def worker_alive(): | |||
| # that the worker process is still alive. | |||
| os.kill(worker.pid, signal.SIGKILL) | |||
| except OSError as e: | |||
| if "No such process" not in e.strerror: | |||
| # Compare errno to the errno for "No such process" | |||
| if e.errno != errno.ESRCH: | |||
jbbarth
force-pushed
the
enhancement/kill-worker
branch
from
290f2bd
to
0f0bdc0
Compare
|
Worked this time... The PR about json_dumps/sort_key would be welcome though! Thanks! |
|
#264, maybe I'll merge it without waiting Travis to timeout |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we use SIGKILL here, which might look a bit violent for the
purpose of stopping a process (the process won't be able to cleanup
anything before dying for instance). This should probably be a SIGTERM
but we already handle SIGTERM signals today and we alias it to a
graceful shutdown. Maybe we should change this behavior, but that's a
first version.
Closes #88.