Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'mark_seen' sender action #49

Merged
merged 4 commits into from Mar 10, 2018
Merged

Conversation

drobee
Copy link
Contributor

@drobee drobee commented Nov 29, 2017

No description provided.

@codecov
Copy link

codecov bot commented Nov 29, 2017

Codecov Report

Merging #49 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #49      +/-   ##
============================================
- Coverage      69.4%   69.34%   -0.06%     
- Complexity      367      368       +1     
============================================
  Files            33       33              
  Lines           902      907       +5     
============================================
+ Hits            626      629       +3     
- Misses          276      278       +2
Impacted Files Coverage Δ Complexity Δ
src/FacebookDriver.php 82.18% <100%> (-0.66%) 68 <1> (+1)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 554540b...aee9e6f. Read the comment docs.

@drobee
Copy link
Contributor Author

drobee commented Dec 5, 2017

@mpociot i think we can't write a test for this, so the code coverage wouldn't be better. What's your opinion?

@mpociot mpociot merged commit 24e3338 into botman:master Mar 10, 2018
@drobee drobee deleted the feature-mark-seen branch June 12, 2018 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants