added quick reply feature

[abhishekchotaliya]

No description provided.

[coveralls]

Coverage decreased (-0.6%) to 4.667% when pulling 964a69c on abhishekchotaliya:master into a216e97 on botmasterai:master.

[coveralls]

Coverage decreased (-0.3%) to 4.965% when pulling 5f8738a on abhishekchotaliya:master into a216e97 on botmasterai:master.

[abhishekchotaliya]

Please note that some changes are required in the botmaster repository to implement quick reply feature in botmaster-twitter-dm.

[jdwuarin]

Thanks for this request. I've added a few comments above so that I can merge the code in. Should be like 5 minutes to do so.

Cheers

[jdwuarin]

These console.logs should be removed

[jdwuarin]

Rename newObj to quickReplyFormattedMessage and should be const

[jdwuarin]

This code should look like this:

return new Promise((resolve, reject) => {
  // if sending events like quick replies, add /events to url
  this.twit.post(`direct_messages${rawMessage.event ? '/events/' : '/'}new`, rawMessage, (err, data) => {
    if (err) {
      reject(err);
    }
    resolve(data);
  });
});

or if wanting to be more explicit:

// if sending events like quick replies, add /events to url
const sendMessageUrl = rawMessage.event ? 'direct_messages/events/new' : 'direct_messages/new'
return new Promise((resolve, reject) => {
  this.twit.post(sendMessageUrl, rawMessage, (err, data) => {
    if (err) {
      reject(err);
    }
    resolve(data);
  });
});

[jdwuarin]

data should be renamed to quickReplies. It should be a const as the object is never overwritten. You should be using the eslint config from the project here (found in the lib directory)

[jdwuarin]

this whole code should be changed to:

const quickReplies = message.message.quick_replies.map(quickReply => ({
  label: quickReply['title'],
  metadata: quickReply['title']
}))

If you would rather use a loop, it should look like this:

const quickReplies = []
for (const quickReply of message.message.quick_replies) {
  quickReplies.push({
    label: quickReply['title'],
    metadata: quickReply['title']
  })
}

[jdwuarin]

This should then use the quickReplies object

[jdwuarin]

this should be a const as it is not reassigned

[abhishekchotaliya]

Hi @jdwuarin,
I've made all the suggested changes. Hopefully, this time you can merge the branch!

[jdwuarin]

@abhishekchotaliya - looking good to me. If you can confirm that this all works for you with both quick replies and normal messages, I'll go ahead and merge it.

[abhishekchotaliya]

Yeah, it is working with both normal messages and quick replies.
Quick reply implementation is not breaking any existing functionalities.