required changes for twitter quick reply feature #43
Conversation
required changes to support quick reply options for botmaster-twitter-dm module
required changes to support quick reply options for botmaster-twitter-dm module
|
This is not how botmaster is supposed to work. There should never be any mention of any potential. Underlying message format. All the formatting should happen in whichever class extends |
| if (outgoingMessage.quick_replies) { | ||
| twitter_qr = true | ||
| } | ||
| return this.__sendMessage(rawMessage, sendOptions, twitter_qr); |
There was a problem hiding this comment.
The rawMessage object should contain enough information for you to know that this is a quick_reply in the twitter-dm package
| } | ||
| outgoingMessage.addQuickReplies(quickReplies); | ||
| outgoingMessage.addQuickReplies(this.type, quickReplies); |
There was a problem hiding this comment.
this.type is also available in the botmaster-twitter-dm BotClass object. No need to include it here. addQuickReplies should have a different behaviour, this should be done by overriding the method in the TwitterDMBot class. But it doesn't look necessary here.
|
Thanks for the suggestions! |
These changes are required for twitter dm package to support quick reply feature.