Merge pull request #1963 from danielgtaylor/ddb-binary

Require a string value to instantiate Binary DynamoDB type. Fixes #1963, #1956.

boto/dynamodb/types.py

@@ -136,6 +136,9 @@ def dynamize_value(val):
 
 class Binary(object):
     def __init__(self, value):
+        if not isinstance(value, basestring):
+            raise TypeError('Value must be a string of binary data!')
+
         self.value = value
 
     def encode(self):

tests/unit/dynamodb/test_types.py

@@ -78,5 +78,17 @@ def test_lossy_float_conversions(self):
         self.assertEqual(dynamizer.decode({'NS': ['1.1', '2.2', '3.3']}),
                          set([1.1, 2.2, 3.3]))
 
+
+class TestBinary(unittest.TestCase):
+    def test_bad_input(self):
+        with self.assertRaises(TypeError):
+            data = types.Binary(1)
+
+    def test_good_input(self):
+        data = types.Binary(chr(1))
+
+        self.assertEqual('\x01', str(data))
+
+
 if __name__ == '__main__':
     unittest.main()