This repository has been archived by the owner on May 10, 2024. It is now read-only.
Enable connect_to_region('us-gov-west-1') for all services in GovCloud #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added region information to the __init__.py for each service additional updates supporting govcloud functionality: - update auth.py HmacAuthV4Handler to return the correct region name - update iam/connection.py to return the correct IAM signin url for govcloud
|
Mostly LGTM. The one thing I'd ask is for test coverage on the changes to the |
1 similar comment
|
Mostly LGTM. The one thing I'd ask is for test coverage on the changes to the |
validate two existing use cases with iam.amazonaws.com and iam.us-gov.amazonaws.com as well as the potential use case of iam.<some-region>.amazonaws.com with the non-existant iam.us-west-1.amazonaws.com
|
Thanks! Merged! |
|
Very cool, thank you |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added us-gov-west-1 region information to the init.py for each service
additional updates supporting govcloud functionality: