This repository has been archived by the owner on May 10, 2024. It is now read-only.
Add support for AWS Direct Connect #1894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| connections = conn.describe_connections() | ||
|
|
||
| assert connections |
There was a problem hiding this comment.
This probably needs to be something like: self.assertTrue('connections' in connections), to look for a key within the response body.
|
|
danielgtaylor
added a commit
that referenced
this pull request
Dec 5, 2013
Add support for AWS Direct Connect. Fixes #1894.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for AWS Direct Connect:
http://docs.aws.amazon.com/directconnect/latest/APIReference/Welcome.html
Due to the nature of Direct Connect there is only a very basic unit and integration test, but it is enough to show that boto can talk to the service and parse its responses.
@toastdriven, please review.