S3 generate signed downloading url is not using response headers

[peterneyens]

I'm trying to generate a download url for an S3 file/key and want to change the filename when the downloaded file is saved locally (using the Content-Disposition header).

disposition = "attachment; filename=\"{}\"".format(file_name)
response_headers = {
    'response-content-disposition': disposition
}
key.generate_url(60 * 60, query_auth=True, response_headers=response_headers)

The key.generate_url method uses the s3.connection.generate_url_sigv4 method and this function doesn't seem to use the response_headers argument, so my Content-Disposition header is not used in the response.

In the normal s3.connection.generate_url, the response headers are added to the query path like described in the S3 documentation.

Kind regards,
Peter

[joelcox]

Thanks for this fix @peterneyens.