Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making 'oldest_date' a mandatory positional parameter. #1012

Merged
merged 1 commit into from Sep 24, 2012
Merged

Making 'oldest_date' a mandatory positional parameter. #1012

merged 1 commit into from Sep 24, 2012

Conversation

oozie
Copy link
Contributor

@oozie oozie commented Sep 24, 2012

The keyword parameter oldest_date= in Layer1.list_open_workflow_executions is mandatory, as per https://forums.aws.amazon.com/thread.jspa?threadID=95420
It's indeed OK to leave the closing value, latest_date, of the startTimeFilter range undefined, but oldest_date must be there.

@oozie
Copy link
Contributor Author

oozie commented Sep 24, 2012

To illustrate on a code example:

>>> layer1.list_open_workflow_executions('test')
---------------------------------------------------------------------------
SWFResponseError                          Traceback (most recent call last)
[...]
SWFResponseError: SWFResponseError: 400 Bad Request
{'message': "1 validation error detected: Value null at 'startTimeFilter.oldestDate' failed to satisfy constraint: Member must not be null", '__type': 'com.amazon.coral.validate#ValidationException'}
##
#  ^^^ layer1 should've required a mandatory arugment. 
##
>>> layer1.list_open_workflow_executions('test', oldest_date=time.time())
{'executionInfos': []}

garnaat added a commit that referenced this pull request Sep 24, 2012
Making 'oldest_date' a mandatory positional parameter.
@garnaat garnaat merged commit 1c800bd into boto:develop Sep 24, 2012
msabramo pushed a commit to msabramo/boto that referenced this pull request Nov 28, 2012
Making 'oldest_date' a mandatory positional parameter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants