Support for Route53 health checks and health checked and failover records #1496
Conversation
…te_record methods
…ute53 healthchecked records
* Includes commit '0e261dcb09398e6eab1e60fefd2f4f14c9526cf9' from @xbe fork
* Adds support for creating/deleting healthchecks
| check_dict = check_dict['HealthCheckConfig'] | ||
| for key in check_dict: | ||
| if key == 'FullyQualifiedDomainName': | ||
| self.__setattr__('host', check_dict[key]) |
There was a problem hiding this comment.
Why are these self.__setattr__(...) calls instead of setattr(self, ...) calls?
|
Thanks for the pull request, patch looks alright. However, given how much this touches, we definitely need some tests to make sure we don't regress as mentioned in the contributing guide. If you could write some tests, that would help a lot. Otherwise this will have to wait until a core dev can find some time to write tests for this. Thanks again for the pull request. |
|
Hey, people, so how about health checks ? |
|
Any plans for this to get merged ? |
|
@boyand somebody needs to add tests to get this merged as mentioned above. At the moment the core developers are working on other issues. |
|
@danielgtaylor This pull request was fixed by e49dc3c no? For people finding this from Google (it's the top-ranked result for "boto route 53 healthcheck" for me), this functionality is supported in Boto already. |
|
Looking at #2054 I didn't see the support for the Failover tag included, which was part of #1496. Can that part of this pull get merged in as well? https://github.com/PressLabs/boto/commit/3281f01f032773f64e46a0e7d4730f4a86a68ff1 had this change as did 0e261dc |
boto.route53.zone.Zonemethodsadd_record()andupdate_record()support failover and health checked records