Synchronize get_all_snapshots() with current version of API #1554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, patch looks reasonable. However, to get this merged, we need some tests to make sure we don't regress as mentioned in the contributing guide. If you could write some tests, that would help a lot. Otherwise this will have to wait until a core dev can find some time to write tests for this. Thanks again for the pull request! |
mbarrien
added a commit
to mbarrien/boto
that referenced
this pull request
Oct 25, 2013
rjschwei
pushed a commit
to rjschwei/boto
that referenced
this pull request
Nov 9, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According current specification 'DescribeSnapshots' API call accepts 'Owner' and 'RestorableBy' parameters as a lists.
I've tried to created this change in backward compatible manner.