Finished implementation of RDS's DescribeDBLogFiles #2084

Merged
merged 1 commit into from Feb 18, 2014

Projects

None yet

3 participants

@pasc
Contributor
pasc commented Feb 8, 2014

This commit implements the missing arguments for get_all_logs.

It introduces two slight API changes. They're the right thing to do, but I can revert those parts if needed.

a) dbinstance_id is no longer optional. It's a required field in the docs, so there's no reason for it to be optional.

b) max_records was previously hardcoded to 26. It's actually an optional field, so I've changed to be so.

@garnaat
Member
garnaat commented Feb 8, 2014

LGTM.

BTW, thanks for all of your contributions recently @pasc. We really appreciate it!

@pasc
Contributor
pasc commented Feb 8, 2014

@garnaat : You're welcome!!

@danielgtaylor
Member

Looks great, thanks!

@danielgtaylor danielgtaylor merged commit f3c706c into boto:develop Feb 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment