Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ~ as safe field for connection build_url_base #2331

Closed
wants to merge 1 commit into from

Conversation

bpicolo
Copy link

@bpicolo bpicolo commented Jun 17, 2014

Without this key signing through Amazon will actually fail for any keys with a ~ inside of them. (I.E. key.generate_url -> connection.generate_url returns a URL that isn't validly signed).

@bpicolo
Copy link
Author

bpicolo commented Jun 17, 2014

I guess that description was bad. Let me explain better.

~ is a valid character in a URL. When you sign the UTF8 encoded version, the equivalent link with a ~ is not validly signed. A browser will automatically convert (%7E I think it is) to ~ for the request, so you will not hit a validly signed link.

At least, that's what it seems like to me. Then again, CURL seems to fail as well, so it might just be that signing with %7E will never be valid.

@danielgtaylor
Copy link
Member

Can you please add a unit test covering this use case? We need to make sure not to break both existing behavior and to not break this new behavior in the future.

@danielgtaylor danielgtaylor self-assigned this Jul 1, 2014
@bpicolo
Copy link
Author

bpicolo commented Jul 1, 2014

Sure.

Would it be possible to get a little feedback on this, I suppose? I'm not particularly experienced with the boto library. Offhand, does what I described seem accurate?

@bpicolo bpicolo closed this May 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants