Add route53 get_checker_ip_ranges method #2792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class TestGetCheckerIpRanges(AWSMockServiceTestCase): | ||
| connection_class = Route53Connection | ||
|
|
||
| def setUp(self): |
There was a problem hiding this comment.
This just calls super so this method can be removed.
|
Aside from the minor style comments above this looks great. Please fix and ping me to get this merged in! 👍 |
|
@danielgtaylor Please take another look. Thanks! |
danielgtaylor
added a commit
that referenced
this pull request
Dec 2, 2014
Adds support for getting health checker IP ranges from Route53. Fixes #2792.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets a list of the IP ranges used by Amazon Route 53 health checkers to check the health of your resources.
http://docs.aws.amazon.com/Route53/latest/APIReference/API_GetCheckerIpRanges.html