Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix incorrect handling of route tables containing propagatingVgwSet, add... #3047

Closed
wants to merge 3 commits into from
Closed

Fix incorrect handling of route tables containing propagatingVgwSet, add... #3047

wants to merge 3 commits into from

Conversation

ojongerius
Copy link
Contributor

... origin to Route objects.

Fixes #3049

@ojongerius ojongerius mentioned this pull request Mar 17, 2015
Closed
@mtdowling
Copy link
Contributor

This seems to be a duplicate of #3046. Should this one be closed?

@ojongerius
Copy link
Contributor Author

@mtdowling this PR includes route origin. As both are related I'll close #3046 and will address your remarks in this one.

  • Change propagatingvgws to propagating_vgws
  • Assert that propagating_vgws is actually populated
  • Rebase against the latest develop

@ojongerius ojongerius mentioned this pull request Aug 21, 2015
Closed
@ojongerius
Copy link
Contributor Author

@mtdowling have added tests. Good to merge?

@ojongerius
Copy link
Contributor Author

Just noticed this has been open for a year. 😩 @JordonPhillips or @kyleknap I see you both have been active on this project. Care to give feedback or merge?

@ojongerius
Copy link
Contributor Author

Guess this is not happening.

@ojongerius ojongerius closed this Sep 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
vpc Waiting for Comments
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect boto.vpc.routetable.RouteTable objects with propagated routes
3 participants
@ojongerius @mtdowling @kyleknap