Allow specifying s3 host from boto config file. #3738
Conversation
|
@mfschwartz - could you give this a review? |
|
Note: This aims to address https://issuetracker.google.com/issues/62161892 |
| no_host_provided = True | ||
| host = self.DefaultHost | ||
| host = boto.config.get('s3', 'host') | ||
| if host is None: |
There was a problem hiding this comment.
It would be more Pythonic to do:
if not host:
There was a problem hiding this comment.
I'm explicitly checking for NoneType here (which is the default from get() if 'host' isn't found in the boto config).
from our style guide: "Beware of writing if x: when you really mean if x is not None:-e.g., when testing whether a variable or argument that defaults to None was set to some other value. The other value might be a value that's false in a boolean context!"
| self.assertIn( | ||
| check.cache_control, | ||
| ('public,%20max-age=500', 'public, max-age=500') | ||
| ) |
There was a problem hiding this comment.
This change looks unrelated to the CL description?
There was a problem hiding this comment.
Yep - didn't mention it in the commit message, but I put a little note about it at the bottom of the pull request. It's just been an annoying test "failure" to have to look over every time I run the s3 integration tests.
This allows users to specify a value for s3:host in their Boto config file, rather than needing to pass the host directly to the constructor for S3Connection. There are some situations (e.g. when using gsutil) where users don't have direct control over how the constructor is called; this allows passing the host argument in such scenarios.
(This also fixes an s3 integration test flake.)