DynamoDB Table object not correctly updating when calling update_throughput #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The update_throughput method of Layer2 calls the update_from_response method of Table, but instead of passing in the full response (as all other similar calls to update_from_response do in the codebase) it passes in response['TableDescription']. Since update_from_response looks for either the key 'Table' or 'TableDescription' in the response object, neither is found and, therefore, the table's local attributes are not updated and do not correctly reflect the changes that have taken place on the server. This fix passes in the full response object to update_from_response.
garnaat
added a commit
that referenced
this pull request
Feb 22, 2012
DynamoDB Table object not correctly updating when calling update_throughput
msabramo
pushed a commit
to msabramo/boto
that referenced
this pull request
Nov 28, 2012
DynamoDB Table object not correctly updating when calling update_throughput
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
update_throughputmethod ofLayer2calls theupdate_from_responsemethod of
Table, but instead of passing in the full response (as allother similar calls to
update_from_responsedo) itpasses in
response['TableDescription']. Sinceupdate_from_responselooks for either the key 'Table' or 'TableDescription' in the response
object, neither is found and, therefore, the table's local attributes
are not updated and do not correctly reflect the changes that have
taken place on the server. This fix passes in the full response object
to
update_from_responseto resolve the issue.