Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersphinx Inventory broken as of 1.26.81 #3610

Closed
potiuk opened this issue Mar 2, 2023 · 4 comments · Fixed by #3615
Closed

Intersphinx Inventory broken as of 1.26.81 #3610

potiuk opened this issue Mar 2, 2023 · 4 comments · Fixed by #3615
Assignees
Labels
bug This issue is a confirmed bug. documentation This is a problem with documentation. p2 This is a standard priority issue

Comments

@potiuk
Copy link

potiuk commented Mar 2, 2023

Describe the issue

Seems that as of 1.26.81 release of boto, intersphinx inventory is broken.

The inventory (https://boto3.amazonaws.com/v1/documentation/api/latest/objects.inv) has gotten significantly bigger as of 1.26.81 and it does not contain many of the methods that were there before:

You can see airflow documentation builds failing for example here:

https://github.com/apache/airflow/actions/runs/4308610594/jobs/7515244502

The above build shows 155 missing symbols.

This is clearly visible in the sizes of the inventories that jumped from 130 K to 175 K (downloaded by replacing latest by specific versions):

⌁ [jarek:~/Downloads] [airflow-3.9] % ls -la objects*
-rw-r--r--@ 1 jarek  staff  130677 Mar  2 08:19 objects_1.26.80.inv
-rw-r--r--@ 1 jarek  staff  175114 Mar  2 08:18 objects_1.26.81.inv
-rw-r--r--@ 1 jarek  staff  175114 Mar  2 08:16 objects_1.26.82.inv

The lack of methods can be seen using sphobjinv tool (example missing method: STS.Client.get_caller_identity) - and you can see that despite bigger size, there are far less number of objects in the inventory:

⌁ [jarek:~/code/airflow/docs/_inventory_cache/boto3] [airflow-3.9] main+ 17s 130 ± sphobjinv su ~/Downloads/objects_1.26.80.inv  STS.Client.get_caller_identity

------------------------------------------------------------------------------------------------------------------------

Cannot infer intersphinx_mapping from a local objects.inv.

------------------------------------------------------------------------------------------------------------------------

Project: Boto3 Docs
Version: 1.26.80

21245 objects in inventory.

------------------------------------------------------------------------------------------------------------------------

1 result found at/above current threshold of 75.

:py:method:`STS.Client.get_caller_identity`

Compare with:

⌁75% [jarek:~/code/airflow/docs/_inventory_cache/boto3] [airflow-3.9] main+ 17s ± sphobjinv su ~/Downloads/objects_1.26.81.inv  STS.Client.get_caller_identity

------------------------------------------------------------------------------------------------------------------------

Cannot infer intersphinx_mapping from a local objects.inv.

------------------------------------------------------------------------------------------------------------------------

Project: Boto3 Docs
Version: 1.26.81

15791 objects in inventory.

------------------------------------------------------------------------------------------------------------------------

No results found with score at/above current threshold of 75.

Exiting...

Links

https://boto3.amazonaws.com/v1/documentation/api/latest/objects.inv

@potiuk potiuk added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Mar 2, 2023
@potiuk potiuk changed the title Intersphinx Inventory broken as of 2.26.81 Intersphinx Inventory broken as of 1.26.81 Mar 2, 2023
@potiuk
Copy link
Author

potiuk commented Mar 2, 2023

Updated version to be correct (1.26 instead of 2.26)

potiuk added a commit to potiuk/airflow that referenced this issue Mar 2, 2023
Boto3 interspinx repository got broken as of 1.26.81 and it is
being tracked in boto/boto3#3610

This PR fixes the version of the inventory to 1.26.80 which is the
latest known correct inventory version.
potiuk added a commit to apache/airflow that referenced this issue Mar 2, 2023
Boto3 interspinx repository got broken as of 1.26.81 and it is
being tracked in boto/boto3#3610

This PR fixes the version of the inventory to 1.26.80 which is the
latest known correct inventory version.
@tim-finnigan tim-finnigan self-assigned this Mar 6, 2023
@tim-finnigan
Copy link
Contributor

Thanks @potiuk for reporting this issue. The boto3 team has created the following PRs to address this:

@tim-finnigan tim-finnigan added bug This issue is a confirmed bug. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 6, 2023
@tim-finnigan tim-finnigan linked a pull request Mar 6, 2023 that will close this issue
@tim-finnigan tim-finnigan added the p2 This is a standard priority issue label Mar 6, 2023
@potiuk
Copy link
Author

potiuk commented Mar 6, 2023

Thanks @potiuk for reporting this issue. The boto3 team has created the following PRs to address this:

Cool. Thanks for notifying ! I will subscribe to those issues and I am happy to help with testing once this issue is addressed.

@potiuk
Copy link
Author

potiuk commented Apr 1, 2023

Confirm the problem is fixed. Thanks!

ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 12, 2023
Boto3 interspinx repository got broken as of 1.26.81 and it is
being tracked in boto/boto3#3610

This PR fixes the version of the inventory to 1.26.80 which is the
latest known correct inventory version.

GitOrigin-RevId: 1b17559f76427a999fc2e46497296af93c559d23
ahidalgob pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Nov 7, 2023
Boto3 interspinx repository got broken as of 1.26.81 and it is
being tracked in boto/boto3#3610

This PR fixes the version of the inventory to 1.26.80 which is the
latest known correct inventory version.

GitOrigin-RevId: 1b17559f76427a999fc2e46497296af93c559d23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a confirmed bug. documentation This is a problem with documentation. p2 This is a standard priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants