Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3.get_bucket_notification doesn't parse response properly. #468

Closed
dokipen opened this issue Feb 2, 2016 · 2 comments
Closed

s3.get_bucket_notification doesn't parse response properly. #468

dokipen opened this issue Feb 2, 2016 · 2 comments

Comments

@dokipen
Copy link

dokipen commented Feb 2, 2016

There can be many instances of CloudFunctionConfiguration in the xml response, but only one is parsed into a python dict. Looks to be a problem in botocore schema?

@jamesls
Copy link
Member

jamesls commented Feb 4, 2016

You'll need to use get_bucket_notification_configuration instead. The docs mention that this is deprecated in favor of get_bucket_notification_configuration.

The history on why we have both methods is that we realized that get_bucket_notification was modeled incorrectly, and as you mention, we were only parsing one element because we didn't model this value as a list.

The problem we ran into was that we could not modify this in a backwards compatible way (for users that only have one configuration and are using the dictionary without issues). Because of this, we decided to create a new method, get_bucket_notification_configuration which was the "correctly modeled" version of this operation and deprecated the old method.

In some future major version of the SDK (way, way in the future) we'll probably remove get_bucket_notification, but for now, we support both methods.

Let me know if you run into any more issues.

@jamesls jamesls closed this as completed Feb 4, 2016
@dokipen
Copy link
Author

dokipen commented Feb 5, 2016

thanks. I realized after I posted, I should have closed it 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants