Rename paginate #119
Merged
Rename paginate #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the parameters to make the collections api less confusing by having only one canonical way of limiting the number of results and sizes of pages. Also ensures consistency of casing of arguments passed to method. Note that for the filter() method, the limit and page_size arguments were just undocumented to signify we do not officially support those parameters.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the collections API to botocore's pagination api change: boto/botocore#547
This also introduces a breaking change where I removed some parameters to make the collections api less confusing by having only one canonical way of limiting the number of results (
limit()method) and sizes of pages (page_size()method). Also this ensures consistency of casing of arguments passed to collections method).Note that for the
filter()method, thelimitandpage_sizearguments were just undocumented to signify we do not officially support those parameters. Let me know what you think about this. I also considered throwing an error if those parameters were ran into in thefilter()sincefilter()takes in only kwargs.cc @jamesls @mtdowling