Add 2015-04-15 version of EC2 resource #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not ready for review, I need to address a few failing tests first. I'll update when this is ready. |
Verifies we generate docs for all resources.
If we update a botocore API version without bumping the corresponding resource API version in boto3, we'll now get a functional test failure. Helps to prevent issues like boto#123 from happening again.
Fixes failing travis builds.
|
Tests fixed, ready to be looked at. |
|
Looks good. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #123.
The issue was that due to a bug in botocore (which is addressed in boto/botocore#554), we were pulling in the latest API version in botocore. However, in boto3's doc generator, when it looked for the corresponding resource model associated with the API version, it didn't find it so we'd skip the EC2 resource documentation. This PR adds that missing API version.
cc @kyleknap @mtdowling