Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 restore additions #408

Merged
merged 3 commits into from
Dec 17, 2015
Merged

S3 restore additions #408

merged 3 commits into from
Dec 17, 2015

Conversation

kyleknap
Copy link
Member

Fixes #380

It adds a start_restore() on Object and ObjectSummary resources. Note that the method is not called restore() because the Object resource already has a restore attribute.

cc @jamesls @mtdowling @rayluo @JordonPhillips

@kyleknap kyleknap changed the title S3 resource S3 restore additions Dec 15, 2015
@JordonPhillips
Copy link
Contributor

an Amazon S3 bucket, determine if a restoration is on-going, and determine if a
restoration is finished.

.. code-block:: python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be an empty line here, to make it a valid REST syntax.

@rayluo
Copy link
Contributor

rayluo commented Dec 15, 2015

🚢 after adding the blank line in the documentation (otherwise doc parser will generate an error).

@jamesls
Copy link
Member

jamesls commented Dec 17, 2015

:shipit: btw it might be worth adding something like doc8 to our travis CI runs. I've started using that in some of my projects and it's been working well so far.

@rayluo rayluo added pr/ready-to-merge This PR is ready to be merged. s3 glacier labels Dec 17, 2015
@kyleknap
Copy link
Member Author

@jamesls I would be fine with doc8 being added as a check in Travis.

kyleknap added a commit that referenced this pull request Dec 17, 2015
@kyleknap kyleknap merged commit 721fbcd into boto:develop Dec 17, 2015
@kyleknap kyleknap deleted the s3-resource branch December 17, 2015 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
glacier pr/ready-to-merge This PR is ready to be merged. s3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants