Switch resource.meta to be an object.
#45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the behavior of the meta object in a **backward-incompatible**
way. It goes from being a dict to an instance of a `ResourceMeta` class.
Example:
```python
import boto3
s3 = boto3.resource('s3')
s3.meta['service_name']
s3.meta['client']
s3.meta.service_name
s3.meta.client
```
| #: (``string``) The service name, e.g. 's3' | ||
| self.service_name = service_name | ||
| #: (``list``) List of identifier names | ||
| self.identifiers = identifiers or [] |
There was a problem hiding this comment.
I think stylistically we should always be using "is not None" if we are comparing against None, which in this scenario we are.
|
Looks good, just some small questions on the ResourceMeta class itself. |
|
|
danielgtaylor
added a commit
that referenced
this pull request
Dec 19, 2014
Switch `resource.meta` to be an object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the behavior of the meta object in a backward-incompatible
way. It goes from being a dict to an instance of a
ResourceMetaclass.Example:
cc @jamesls, @kyleknap