Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclass IOBase with StreamingBody #1361

Closed
wants to merge 1 commit into from
Closed

Subclass IOBase with StreamingBody #1361

wants to merge 1 commit into from

Conversation

abennett
Copy link

@abennett abennett commented Jan 11, 2018

Trying to get the ball rolling on #879 again. I'm new to this, so feedback is desired and appreciated. This change passes the tox tests I've run on my laptop.

@codecov-io
Copy link

codecov-io commented Jan 11, 2018

Codecov Report

Merging #1361 into develop will decrease coverage by 0.01%.
The diff coverage is 80%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1361      +/-   ##
===========================================
- Coverage    98.13%   98.12%   -0.02%     
===========================================
  Files           46       46              
  Lines         7736     7740       +4     
===========================================
+ Hits          7592     7595       +3     
- Misses         144      145       +1
Impacted Files Coverage Δ
botocore/response.py 86.66% <80%> (-1.14%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc8824...202bc45. Read the comment docs.

@abennett abennett closed this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants