Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add specifications for available regions for missing services #1585

Closed
wants to merge 2 commits into from
Closed

Add specifications for available regions for missing services #1585

wants to merge 2 commits into from

Conversation

j-kroll
Copy link

@j-kroll j-kroll commented Oct 22, 2018

Add specifications for available regions for missing services, as raised in the boto3 issue boto/boto3#1662. Below is the source used to identify each service's regions, with the list of services taken from the original issue:

  1. appsync (A)
  2. cloudsearchdomain (B: under CloudSearch)
  3. connect (A)
  4. dlm (B: under EC2)
  5. eks (A)
  6. iot-jobs-data (B: under IoT Device Management)
  7. iotanalytics (n/a - already existed in the file)
  8. macie (A)
  9. mobile (A)
  10. mq (A)
  11. pi (B: under RDS)
  12. transcribe (A)

A: AWS region table
B: AWS console

@codecov-io
Copy link

codecov-io commented Oct 25, 2018

Codecov Report

Merging #1585 into develop will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1585      +/-   ##
===========================================
- Coverage       92%   91.97%   -0.04%     
===========================================
  Files           50       50              
  Lines         9110     9110              
===========================================
- Hits          8382     8379       -3     
- Misses         728      731       +3
Impacted Files Coverage Δ
botocore/credentials.py 98.4% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88b2dd1...f96a2ad. Read the comment docs.

@stealthycoin
Copy link
Contributor

Hi thanks for the contribution, however; this file is given to us from an upstream source and we cannot modify it. These changes would be clobbered in our next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants