Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert IMDS changes #1893

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Revert IMDS changes #1893

merged 1 commit into from
Nov 20, 2019

Conversation

joguSD
Copy link
Contributor

@joguSD joguSD commented Nov 20, 2019

@joguSD
Revert "Merge commit '66a373662c2f75a76ccdcd57aceef3a22e0a24e8' into …
4eae2e7 
…stage-release-develop"

This reverts commit 680fb7e, reversing
changes made to 61f9803.
kyleknap
kyleknap approved these changes Nov 20, 2019
View reviewed changes
Copy link
Member

@kyleknap kyleknap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass 🚢

@joguSD joguSD merged commit abbf707 into boto:develop Nov 20, 2019
@codecov-io
Copy link

codecov-io commented Nov 20, 2019 •
edited

Codecov Report

Merging #1893 into develop will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1893      +/-   ##
===========================================
- Coverage    92.58%   92.57%   -0.02%     
===========================================
  Files           53       53              
  Lines        10033    10001      -32     
===========================================
- Hits          9289     9258      -31     
+ Misses         744      743       -1
Impacted Files Coverage Δ
botocore/utils.py 97.98% <100%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update acee425...4eae2e7. Read the comment docs.

jimmywan
jimmywan reviewed Nov 27, 2019
View reviewed changes
botocore/utils.py
"""Make a get request to the Instance Metadata Service.

:type url_path: str
:param url_path: The path component of the URL to make a get request.
This arg is appended to the base_url that was provided in the
This arg is appended to the base_url taht was provided in the
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, a typo got introduced here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimmywan jimmywan jimmywan left review comments

@kyleknap kyleknap kyleknap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@joguSD @codecov-io @kyleknap @jimmywan