Added tests for new endpoints 2.0 files #2747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonemo
reviewed
Aug 29, 2022
There was a problem hiding this comment.
This is great. I've been burned by tests getting skipped silently due to missing test data files and this will help with that, so 👍 from me!
Do we already have a test elsewhere that asserts that Session().get_available_services() returns more than zero services? If not, that may be worth adding. Otherwise a completely empty data directory would result in these test passing.
I left a few inline comments inline regarding consolidating repeated code.
nateprewitt
requested changes
Aug 30, 2022
nateprewitt
requested changes
Aug 30, 2022
dlm6693
reviewed
Aug 31, 2022
dlm6693
reviewed
Sep 1, 2022
dlm6693
reviewed
Sep 1, 2022
dlm6693
reviewed
Sep 1, 2022
dlm6693
reviewed
Sep 1, 2022
jonemo
reviewed
Oct 14, 2022
Comment on lines
+73
to
+80
| @pytest.mark.parametrize("service_name", AVAILABLE_SERVICES) | ||
| def test_all_endpoint_tests_exist(service_name): | ||
| """Tests the existence of endpoint-tests-1.json for each service | ||
| and verifies that content is present.""" | ||
| endpoint_tests_file = os.path.join(TEST_DATA_DIR, service_name, 'endpoint-tests-1.json') | ||
| with open(endpoint_tests_file) as f: | ||
| data = json.load(f) | ||
| assert len(data['testCases']) >= 1 |
There was a problem hiding this comment.
This is now also covered in my branch (currently in WIP PR jonemo#1) together with all other tests that need to access the tests/functional/endpoint-rules folder.
|
Resolving, this ended up addressed in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes new functional tests that validate the presence and content of new endpoint files such as
endpoint-rule-set.json,endpoint-tests.json, andpartitions.json.