Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove utcnow() calls to fix deprecation warnings encountered in python 3.12 #3093

Closed
wants to merge 1 commit into from

Conversation

dlm6693
Copy link
Contributor

@dlm6693 dlm6693 commented Dec 26, 2023

Replace utcnow() with now(datetime.timezone.utc). Integ tests were run successfully on my local machine. One deprecation warning from python-dateutil is still expected in GitHub CI. The unknown timezone warning is a separate issue that should be addressed in another PR.

@codecov-commenter
Copy link

codecov-commenter commented Dec 26, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (52a4c2c) 93.14% compared to head (dead47d) 93.14%.

Files Patch % Lines
botocore/crt/auth.py 0.00% 2 Missing ⚠️
botocore/auth.py 66.66% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3093   +/-   ##
========================================
  Coverage    93.14%   93.14%           
========================================
  Files           66       66           
  Lines        14237    14238    +1     
========================================
+ Hits         13261    13262    +1     
  Misses         976      976           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nateprewitt
Copy link
Contributor

Resolving for inclusion at a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants