Allow binary to be sent to user data #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary because gzip files can be passed in as user data when launching instances.
| @@ -99,6 +99,20 @@ def test_run_instances_userdata(self): | |||
| # TODO: We need to base64 decode this! Needs a customization | |||
There was a problem hiding this comment.
Uh..just noticing this now. Can we uncomment this assertion and verify it works?
There was a problem hiding this comment.
Yeah I will fix that. I just noticed nothing is asserted here as well. That is why I accidentally did not assert anything in the test I added. I had just modified this test.
|
Let's get the tests updated and then verify that the travis build is clean. Otherwise |
and don't forget to update the CLI changelog.
|
|
kyleknap
added a commit
that referenced
this pull request
Dec 19, 2014
Allow binary to be sent to user data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary because gzip files can be passed in as user data when
launching instances. Such as in this issue: aws/aws-cli#814
Before if you ran:
You would get decoding errors because it is assumed the input to
--user-datais text.Now with this PR the command will work with both text and binary. I tested it manually as well and both my gzip compressed script and text-based shell script ran when I launched my instances.
cc @jamesls @danielgtaylor