Plumb request payer to complete multipart #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyleknap
requested review from
dstufft,
jamesls,
stealthycoin,
joguSD and
JordonPhillips
jamesls
approved these changes
Feb 14, 2018
s3transfer/utils.py
Outdated
| @@ -126,6 +126,24 @@ def invoke_progress_callbacks(callbacks, bytes_transferred): | |||
| callback(bytes_transferred=bytes_transferred) | |||
|
|
|||
|
|
|||
| def get_filtered_extra_args(extra_args, whitelisted_args): | |||
There was a problem hiding this comment.
Can you rename this to something more general? The name makes sense when it's an internal method on the various Task subclasses, but if it's going to be a utility function I think it should be named without any mention of "extra args".
There was a problem hiding this comment.
Yeah I was thinking about that too. I am going to rename it to get_filtered_dict.
|
@jamesls I updated based on feedback. Let me know if you have any feedback on the update. Otherwise, I will probably merge this soon so we can start getting clean runs of the CLI |
JordonPhillips
approved these changes
Feb 14, 2018
jamesls
approved these changes
Feb 14, 2018
This was referenced Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this was not plumbed in when I was working on the
--request-payerfeature for the CLI.