-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --request-payer to transfer commands #3147
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #3147 +/- ##
===========================================
+ Coverage 97.09% 97.11% +0.01%
===========================================
Files 406 407 +1
Lines 33362 33515 +153
===========================================
+ Hits 32394 32547 +153
Misses 968 968
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I played around a little bit with it and it seems to work.
When do you think there will be a version we can pull for testing ? |
This builds on this previous PR: #3016
Compared to the original PR, there was a lot more lines added. For the most part, the logic from the original PR stayed intact. Just I added a lot of functional tests for this as practically all API requests used in a command will require the request payer header or the command will fail, and so I wanted to be sure that I caught all of the different scenarios (good thing I did too because I found a bug in s3transfer as well related to this). I also tested it locally on a bucket enabled for requester pays using an account that does not own the bucket and it was working well there. For anyone following/reviewing this PR, feel free to try it out locally as well and that will help double check I did not miss anything.
Also, note tests won't pass until this PR gets merged from
s3transfer
: boto/s3transfer#103