Support file-like objects in CRT transfer manager #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a backport of this pull request: aws/aws-cli#8291
kyleknap
commented
Nov 2, 2023
| ) | ||
| credetial_resolver = self.session.get_component('credential_provider') | ||
| self.s3_crt_client = s3transfer.crt.create_s3_crt_client( | ||
| self.session.get_config_variable("region"), credetial_resolver |
There was a problem hiding this comment.
It looks like this will pull in a fix that we made in v2 where we were using the session's region. However, we never directly set the region on the session even though we set the region to be us-west-2 for the base test class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of this pull request: aws/aws-cli#8291, which was implemented based off this pull request: #277. Also note that the integration tests do not pass using the current version of CRT that is pinned in
botocore. They do however pass if you update to the latest version ofawscrt. I don't think that should block merging this PR as it will be merged into a feature branch. However, we will need to update theawscrtpin inbotocorebefore merging the feature branch.