Add error translation from S3ResponseError to Botocore errors #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## crt-enhancements #284 +/- ##
====================================================
- Coverage 84.23% 83.01% -1.23%
====================================================
Files 16 16
Lines 2760 2796 +36
====================================================
- Hits 2325 2321 -4
- Misses 435 475 +40 ☔ View full report in Codecov by Sentry. |
kyleknap
reviewed
Nov 24, 2023
Co-authored-by: Michael Graeb <graebm@amazon.com>
nateprewitt
force-pushed
the
crt-error-mapping
branch
from
e2e720a
to
7450ccb
Compare
aws-sdk-python-automation
added a commit
that referenced
this pull request
Nov 27, 2023
* release-0.8.0: Bumping version to 0.8.0 Remove CRT translation integ test (#287) Move minimum botocore version to 1.32.7 (#286) Update minimum version for Botocore Add error translation from S3ResponseError to Botocore errors (#284) Update interface for providing credentials to CRT Update throughput target defaults Add CRT process lock utility Turn on checksum validation for CRT S3 transfer manager Support file-like objects in CRT transfer manager update ci to use GA python 3.12 (#278)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality to the CRT S3 Transfer Manager to handle error translation from the S3 service. This will ensure Boto3 integration retains existing error hierarchy to provide a seamless experience between the two transfer methods.
Merge of this PR is pending boto/botocore#3073 to provide the
operation_nameoff the CRT shape.