Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRTTransferManager validates ExtraArgs and Bucket, same as classic TransferManager #294

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

graebm
Copy link
Contributor

@graebm graebm commented Nov 30, 2023

No description provided.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things to avoid carrying forward outdated syntax that is being addressed in the original code with #308. Otherwise this looks good.

s3transfer/crt.py Outdated Show resolved Hide resolved
s3transfer/crt.py Outdated Show resolved Hide resolved
@nateprewitt nateprewitt merged commit 6461de3 into boto:develop Jun 18, 2024
39 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Jun 24, 2024
* release-0.10.2:
  Bumping version to 0.10.2
  Pass operation name to awscrt.s3 (#309)
  CRTTransferManager validates ExtraArgs and Bucket, same as classic TransferManager (#294)
  Start testing on 3.13 beta build
  Move 3.8 and 3.9 builds back to macos-13
  update wheel to latest release (#303)
  Upgrade pytest and associated test packages (#302)
hswong3i pushed a commit to alvistack/boto-s3transfer that referenced this pull request Jun 25, 2024
…ansferManager (boto#294)

* CRTTransferManager validates ExtraArgs and Bucket, same as classic TransferManager.

---------

Co-authored-by: Nate Prewitt <nate.prewitt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants