Fix retrying incomplete downloads with urllib3 2.x #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #301 +/- ##
========================================
Coverage 82.94% 82.94%
========================================
Files 16 16
Lines 2814 2814
========================================
Hits 2334 2334
Misses 480 480 ☔ View full report in Codecov by Sentry. |
nateprewitt
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Thanks for the PR, @apmorton! Yep, this definitely looks like a missed behavior change when 2.x support was added. We'd be happy to merge this. I made a minor change to fix a linting error, but otherwise this looks good.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
boto/botocore#3132