Check event.user is not null #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fedealconada
pushed a commit
to fedealconada/botpress-api.ai
that referenced
this pull request
Aug 15, 2017
I'm adding a line that checks if event.user is not null. This avoids problems when botpress uses both this and botpress-webhooks modules at the same time.
I'm moving up the line that checks if the event type is a message. This is because where it is now, it first tries to shortUserId with event.user.id and there is a possiblity that evet.user is undefined (e.g when we have botpress-webhooks installed and the webhook is triggered).
|
Hey federico! Could you please sign the CLA so I can merge this? Thanks |
|
Any chance this can get merged? Thanks in advance! |
|
@jbuchacher Done and pushed in newest version! |
|
Nice :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids problems when botpress uses both this and botpress-webhooks modules at the same time.