fix(dx): fix failing tests (#5739)

botpress · Dec 3, 2021 · 84a0bf5 · 84a0bf5
1 parent c31345d
commit 84a0bf5
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/modules/google-speech/src/backend/utils.test.ts b/modules/google-speech/src/backend/utils.test.ts
@@ -1,6 +1,11 @@
 import { closest } from './utils'
 
-const randomNumber = (max = 100) => Math.floor(Math.random() * max)
+const randomNumber = (max = 100) => {
+  const value = Math.floor(Math.random() * max)
+  // Prevents returning 0 because it makes tests fail randomly
+  return value > 1 ? value : randomNumber(max)
+}
+
 const arrayGenerator = (size = 10): number[] => {
   return Array.from({ length: size }, () => randomNumber())
 }

diff --git a/packages/bp/e2e/studio/flows.test.ts b/packages/bp/e2e/studio/flows.test.ts
@@ -51,8 +51,6 @@ describe('Studio - Flows', () => {
   })
 
   it('Open node properties', async () => {
-    const element = await expectMatchElement('.srd-node--selected', { text: /node-[0-9]*/ })
-    await clickOn('div', {}, element)
     await page.waitForSelector('#btn-add-element')
     await clickOn('#btn-add-element')
     await clickOn('.bp3-dialog-close-button')

diff --git a/packages/bp/src/core/events/middleware-chain.test.ts b/packages/bp/src/core/events/middleware-chain.test.ts
@@ -141,8 +141,9 @@ describe('Middleware', () => {
     await Promise.delay(extraTime)
   })
 
-  it('if should let mw set a custom timeout value', async () => {
-    const extraTime = 10
+  it('should let mw set a custom timeout value', async () => {
+    // Avoid a small number, bluebird overhead sometimes makes the test fail
+    const extraTime = 50
     const mock = jest.fn(async (_event: IO.Event) => {
       await Promise.delay(defaultTimeout + extraTime)
     })